morningman commented on code in PR #22224:
URL: https://github.com/apache/doris/pull/22224#discussion_r1275132306
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisManager.java:
##########
@@ -578,63 +580,70 @@ private void createTaskForExternalTable(AnalysisInfo
jobInfo,
}
AnalysisInfoBuilder colTaskInfoBuilder = new
AnalysisInfoBuilder(jobInfo);
long taskId = Env.getCurrentEnv().getNextId();
- AnalysisInfo analysisInfo = colTaskInfoBuilder.setIndexId(-1L)
- .setTaskId(taskId).setExternalTableLevelTask(true).build();
+ AnalysisInfo analysisInfo =
colTaskInfoBuilder.setIndexId(-1L).setLastExecTimeInMs(System.currentTimeMillis())
+
.setTaskId(taskId).setColName("TableRowCount").setExternalTableLevelTask(true).build();
analysisTasks.put(taskId, createTask(analysisInfo));
if (isSync) {
// For sync job, don't need to persist, return here and execute it
immediately.
return;
}
try {
- logCreateAnalysisJob(analysisInfo);
+ logCreateAnalysisTask(analysisInfo);
} catch (Exception e) {
throw new DdlException("Failed to create analysis task", e);
}
}
- public void updateTaskStatus(AnalysisInfo info, AnalysisState jobState,
String message, long time) {
+ public void updateTaskStatus(AnalysisInfo info, AnalysisState taskState,
String message, long time) {
if (analysisJobIdToTaskMap.get(info.jobId) == null) {
return;
}
- info.state = jobState;
+ info.state = taskState;
info.message = message;
+ if (taskState.equals(AnalysisState.FINISHED) ||
taskState.equals(AnalysisState.FAILED)) {
+ info.timeCostInMs = time - info.lastExecTimeInMs;
+ }
info.lastExecTimeInMs = time;
logCreateAnalysisTask(info);
AnalysisInfo job = analysisJobInfoMap.get(info.jobId);
- job.lastExecTimeInMs = time;
- if (info.state.equals(AnalysisState.RUNNING) &&
!job.state.equals(AnalysisState.PENDING)) {
- job.state = AnalysisState.RUNNING;
- Env.getCurrentEnv().getEditLog().logCreateAnalysisTasks(job);
- }
- boolean allFinished = true;
- boolean hasFailure = false;
- for (BaseAnalysisTask task :
analysisJobIdToTaskMap.get(info.jobId).values()) {
- AnalysisInfo taskInfo = task.info;
- if (taskInfo.state.equals(AnalysisState.RUNNING) ||
taskInfo.state.equals(AnalysisState.PENDING)) {
- allFinished = false;
- break;
+ // Synchronize the job state change in job level.
+ synchronized (job) {
+ job.lastExecTimeInMs = time;
+ // Set the job state to RUNNING when its first task becomes
RUNNING.
+ if (info.state.equals(AnalysisState.RUNNING) &&
job.state.equals(AnalysisState.PENDING)) {
+ job.state = AnalysisState.RUNNING;
+ logCreateAnalysisJob(job);
Review Comment:
I think we only need to log the job or task in final state(finished or
cancelled)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
