yangzhg commented on a change in pull request #4242:
URL: https://github.com/apache/incubator-doris/pull/4242#discussion_r464818445
##########
File path: be/src/olap/row_block.cpp
##########
@@ -52,6 +52,7 @@ OLAPStatus RowBlock::init(const RowBlockInfo& block_info) {
_info = block_info;
_null_supported = block_info.null_supported;
_capacity = _info.row_num;
+ _delete_bitmap.reset(new Roaring());
Review comment:
use make_unique
##########
File path: be/src/olap/row_block.cpp
##########
@@ -75,6 +76,7 @@ void RowBlock::clear() {
_pos = 0;
_limit = 0;
_mem_pool->clear();
+ _delete_bitmap.reset(new Roaring());
Review comment:
reset()
##########
File path: be/src/olap/row_block2.h
##########
@@ -59,6 +59,7 @@ class RowBlockV2 {
// all previously returned ColumnBlocks are invalidated after clear(),
accessing them
// will result in undefined behavior.
void clear() {
+ _delete_bitmap.reset(new Roaring());
Review comment:
reset()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
