yiguolei commented on code in PR #22223:
URL: https://github.com/apache/doris/pull/22223#discussion_r1274243952
##########
be/src/vec/data_types/data_type_time_v2.cpp:
##########
@@ -67,6 +67,9 @@ void DataTypeDateV2::to_string(const IColumn& column, size_t
row_num, BufferWrit
UInt32 int_val = assert_cast<const
ColumnUInt32&>(*ptr).get_element(row_num);
DateV2Value<DateV2ValueType> val = binary_cast<UInt32,
DateV2Value<DateV2ValueType>>(int_val);
+ if (!val.is_valid_date()) {
Review Comment:
这里加一些注释，解释一下，否则后来人不明白什么意思
##########
be/src/vec/data_types/data_type_time_v2.cpp:
##########
@@ -67,6 +67,9 @@ void DataTypeDateV2::to_string(const IColumn& column, size_t
row_num, BufferWrit
UInt32 int_val = assert_cast<const
ColumnUInt32&>(*ptr).get_element(row_num);
DateV2Value<DateV2ValueType> val = binary_cast<UInt32,
DateV2Value<DateV2ValueType>>(int_val);
+ if (!val.is_valid_date()) {
Review Comment:
这里加一些注释，解释一下，否则后来人不明白什么意思
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
