[doris] 06/06: [Fix](compaction) return internal error to avoid be core when finalize_columns_data (#21882)

[morningman]

This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 621c82e0ab6ce218a68dfea4d6bcb20571609f6e
Author: huanghaibin <284824...@qq.com>
AuthorDate: Tue Jul 25 15:39:58 2023 +0800

    [Fix](compaction) return internal error to avoid be core when 
finalize_columns_data (#21882)
    
    return error instead of CHECK_EQ to avoid be core when finalize_columns_data
---
 be/src/olap/rowset/segment_v2/segment_writer.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/be/src/olap/rowset/segment_v2/segment_writer.cpp 
b/be/src/olap/rowset/segment_v2/segment_writer.cpp
index e9a5f11285..9125b2f22d 100644
--- a/be/src/olap/rowset/segment_v2/segment_writer.cpp
+++ b/be/src/olap/rowset/segment_v2/segment_writer.cpp
@@ -370,7 +370,14 @@ Status SegmentWriter::finalize_columns(uint64_t* 
index_size) {
     if (_has_key) {
         _row_count = _num_rows_written;
     } else {
-        CHECK_EQ(_row_count, _num_rows_written);
+        DCHECK(_row_count == _num_rows_written)
+                << "_row_count != _num_rows_written:" << _row_count << " vs. " 
<< _num_rows_written;
+        if (_row_count != _num_rows_written) {
+            std::stringstream ss;
+            ss << "_row_count != _num_rows_written:" << _row_count << " vs. " 
<< _num_rows_written;
+            LOG(WARNING) << ss.str();
+            return Status::InternalError(ss.str());
+        }
     }
     _num_rows_written = 0;
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org