morningman commented on a change in pull request #4158: URL: https://github.com/apache/incubator-doris/pull/4158#discussion_r464313843
########## File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java ########## @@ -1397,4 +1401,36 @@ public void readFields(DataInput in) throws IOException { throw new IOException("error happens when parsing create routine load stmt: " + origStmt, e); } } + + abstract public void modifyProperties(AlterRoutineLoadStmt stmt) throws DdlException; Review comment: Maybe we could do this when we got second derived class from RoutineLoadJob ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org