yiguolei commented on code in PR #22144:
URL: https://github.com/apache/doris/pull/22144#discussion_r1273397225


##########
fe/fe-core/src/main/java/org/apache/doris/qe/cache/CacheAnalyzer.java:
##########
@@ -288,8 +289,64 @@ private CacheMode innerCheckCacheMode(long now) {
         return CacheMode.Partition;
     }
 
+    private CacheMode innerCheckCacheModeForNereids(long now) {
+        // only sql cache
+        if (!enableSqlCache()) {
+            LOG.debug("sql cache is disabled. queryid {}", 
DebugUtil.printId(queryId));

Review Comment:
   if (log.isdebugenabled) 



##########
fe/fe-core/src/main/java/org/apache/doris/qe/cache/CacheAnalyzer.java:
##########
@@ -288,8 +289,64 @@ private CacheMode innerCheckCacheMode(long now) {
         return CacheMode.Partition;
     }
 
+    private CacheMode innerCheckCacheModeForNereids(long now) {
+        // only sql cache
+        if (!enableSqlCache()) {
+            LOG.debug("sql cache is disabled. queryid {}", 
DebugUtil.printId(queryId));
+            return CacheMode.NoNeed;
+        }
+        if (!(parsedStmt instanceof LogicalPlanAdapter) || scanNodes.size() == 
0) {
+            LOG.debug("not a select stmt or no scan node. queryid {}", 
DebugUtil.printId(queryId));

Review Comment:
   and here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to