morrySnow commented on code in PR #22177:
URL: https://github.com/apache/doris/pull/22177#discussion_r1272944562
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -1422,7 +1425,7 @@ private void computeMultiCastFragmentParams() throws
Exception {
List<TPlanFragmentDestination> destinations =
multiSink.getDestinations().get(i);
if (enablePipelineEngine &&
enableShareHashTableForBroadcastJoin
- && params.fragment.isRightChildOfBroadcastHashJoin()) {
+ && destFragment.isRightChildOfBroadcastHashJoin()) {
Review Comment:
according to the silimar code in `computeFragmentExecParams`, this code
block is to want to decide how to shuffle data to dest by whether it is
broadcast join's right child. Since `MultiCastFragment` will never be broadcast
join's right child. I think the right way to fix this problem is removing if
branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
