kangkaisen commented on a change in pull request #4190:
URL: https://github.com/apache/incubator-doris/pull/4190#discussion_r462713558
##########
File path: gensrc/proto/internal_service.proto
##########
@@ -147,6 +147,59 @@ message PFetchDataResult {
optional PQueryStatistics query_statistics = 4;
};
+//Add message definition to fetch and update cache
+enum PCacheStatus {
+ DEFAULT = 0;
+ CACHE_OK = 1;
+ PARAM_ERROR = 2;
+ SIZE_OVER_LIMIT = 3;
+ NO_SQL_KEY = 4;
+ NO_PARTITION_KEY = 5;
+ INVALID_KEY_RANGE = 6;
+ DATA_OVERDUE = 7;
+ EMPTY_DATA = 8;
+};
+
+message PCacheParam {
+ required int64 partition_key = 1;
Review comment:
For protobuf, we prefer optional than required.
##########
File path: gensrc/proto/internal_service.proto
##########
@@ -147,6 +147,59 @@ message PFetchDataResult {
optional PQueryStatistics query_statistics = 4;
};
+//Add message definition to fetch and update cache
+enum PCacheStatus {
+ DEFAULT = 0;
+ CACHE_OK = 1;
+ PARAM_ERROR = 2;
+ SIZE_OVER_LIMIT = 3;
+ NO_SQL_KEY = 4;
+ NO_PARTITION_KEY = 5;
+ INVALID_KEY_RANGE = 6;
+ DATA_OVERDUE = 7;
+ EMPTY_DATA = 8;
+};
+
+message PCacheParam {
+ required int64 partition_key = 1;
+ required int64 last_version = 2;
+ required int64 last_version_time = 3;
+};
+
+message PCacheValue {
+ required PCacheParam param = 1;
+ required int32 data_size = 2;
+ repeated bytes row = 3;
+};
+
+//for update&clear return
+message PCacheResponse {
+ required PCacheStatus status = 1;
+};
+
+message PUpdateCacheRequest{
+ required PUniqueId sql_key = 1;
+ repeated PCacheValue value = 2;
+};
+
+message PFetchCacheRequest {
+ required PUniqueId sql_key = 1;
+ repeated PCacheParam param = 2;
+};
+
+message PFetchCacheResult {
+ required PCacheStatus status = 1;
+ repeated PCacheValue value = 2;
+};
+
+message PClearCacheRequest {
+ //0 clear all, 1 invoke prune, 2 clear before_time, 3 clear sql_key
+ required int32 clear_type = 1;
Review comment:
Would better define the clear_type to enum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
