morningman commented on a change in pull request #4148:
URL: https://github.com/apache/incubator-doris/pull/4148#discussion_r462139372
##########
File path: fe/fe-core/src/main/java/org/apache/doris/master/ReportHandler.java
##########
@@ -481,7 +481,6 @@ private static void sync(Map<Long, TTablet> backendTablets,
ListMultimap<Long, L
// 1. PUSH finished in BE but failed or not yet
report to FE
// 2. repair for VERSION_INCOMPLETE finished in
BE, but failed or not yet report to FE
replica.updateVersionInfo(backendVersion,
backendVersionHash, dataSize, rowCount);
- replica.setBad(false);
Review comment:
For reviewer:
In the original design logic, when the status of a replica is bad, it cannot
become not bad again.
This is a clerical error and will cause the `admin set replica status`
function to fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
