morrySnow commented on code in PR #22074:
URL: https://github.com/apache/doris/pull/22074#discussion_r1270358111
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalCatalogRelation.java:
##########
@@ -81,10 +82,17 @@ public TableIf getTable() {
}
@Override
- public Database getDatabase() throws AnalysisException {
- Preconditions.checkArgument(!qualifier.isEmpty());
- return
Env.getCurrentInternalCatalog().getDbOrException(qualifier.get(0),
- s -> new AnalysisException("Database [" + qualifier.get(0) +
"] does not exist."));
+ public DatabaseIf getDatabase() throws AnalysisException {
+ Preconditions.checkArgument(qualifier.size() == 3);
Review Comment:
add check error msg
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalCatalogRelation.java:
##########
@@ -64,10 +66,17 @@ public TableIf getTable() {
}
@Override
- public Database getDatabase() throws AnalysisException {
- Preconditions.checkArgument(!qualifier.isEmpty());
- return
Env.getCurrentInternalCatalog().getDbOrException(qualifier.get(0),
- s -> new AnalysisException("Database [" + qualifier.get(0) +
"] does not exist."));
+ public DatabaseIf getDatabase() throws AnalysisException {
+ Preconditions.checkArgument(qualifier.size() == 3);
Review Comment:
add check error msg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
