xzj7019 commented on code in PR #21883:
URL: https://github.com/apache/doris/pull/21883#discussion_r1270349729


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/PhysicalSetOperation.java:
##########
@@ -130,4 +137,41 @@ public int getArity() {
         return children.size();
     }
 
+    @Override
+    public boolean pushDownRuntimeFilter(CascadesContext context, 
IdGenerator<RuntimeFilterId> generator,

Review Comment:
   it is not convivent to write the rf pushing down in current runtime filter 
generator visit framework, since the rf producer is the join node, but it can 
be pushed down into the very deep scan node, inside different layer of 
subquery, set op, etc.  Seems transferMap is not enough, which only maintains 
the probeExpr's visibility, but not provide the facility for the pushing down 
between different plan tree layer. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to