yujun777 commented on code in PR #21418:
URL: https://github.com/apache/doris/pull/21418#discussion_r1270261120
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java:
##########
@@ -63,13 +58,33 @@ protected void runAfterCatalogReady() {
}
}
- private boolean
isAllBackendsOfUnfinishedTasksDead(List<PublishVersionTask> unfinishedTasks) {
- for (PublishVersionTask unfinishedTask : unfinishedTasks) {
- if
(Env.getCurrentSystemInfo().checkBackendAlive(unfinishedTask.getBackendId())) {
- return false;
+ private void genPublishErrorReplicas(TransactionState transactionState) {
+ TabletInvertedIndex tabletInvertedIndex =
Env.getCurrentInvertedIndex();
+ Map<Long, Set<Long>> publishErrorReplicas = Maps.newHashMap();
+ for (PublishVersionTask task :
transactionState.getPublishVersionTasks().values()) {
+ long backendId = task.getBackendId();
+ if (!task.isFinished()) {
+ continue;
+ }
+ Set<Long> errorReplicas = Sets.newHashSet();
+ for (Long tabletId : task.getErrorTablets()) {
+ if (tabletInvertedIndex.getTabletMeta(tabletId) == null) {
+ continue;
Review Comment:
done print log
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java:
##########
@@ -63,13 +58,33 @@ protected void runAfterCatalogReady() {
}
}
- private boolean
isAllBackendsOfUnfinishedTasksDead(List<PublishVersionTask> unfinishedTasks) {
- for (PublishVersionTask unfinishedTask : unfinishedTasks) {
- if
(Env.getCurrentSystemInfo().checkBackendAlive(unfinishedTask.getBackendId())) {
- return false;
+ private void genPublishErrorReplicas(TransactionState transactionState) {
+ TabletInvertedIndex tabletInvertedIndex =
Env.getCurrentInvertedIndex();
+ Map<Long, Set<Long>> publishErrorReplicas = Maps.newHashMap();
+ for (PublishVersionTask task :
transactionState.getPublishVersionTasks().values()) {
+ long backendId = task.getBackendId();
+ if (!task.isFinished()) {
+ continue;
+ }
+ Set<Long> errorReplicas = Sets.newHashSet();
+ for (Long tabletId : task.getErrorTablets()) {
+ if (tabletInvertedIndex.getTabletMeta(tabletId) == null) {
+ continue;
+ }
+ Replica replica = tabletInvertedIndex.getReplica(tabletId,
backendId);
+ if (replica != null) {
+ errorReplicas.add(replica.getId());
+ }
Review Comment:
done print log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
