xinyiZzz commented on code in PR #22027:
URL: https://github.com/apache/doris/pull/22027#discussion_r1270247408
##########
be/src/vec/common/allocator.h:
##########
@@ -95,6 +96,8 @@ class Allocator {
/// Allocate memory range.
void* alloc(size_t size, size_t alignment = 0) {
memory_check(size);
+ doris::thread_context()->large_memory_check = false;
Review Comment:
因为 Allocator 申请大内存是符合预期的，
Allocator之外申请大内存不符合预期，如果发现了，期望能改用Allocator申请，否则内存超限后不受控制的大内存申请容易导致OOM
##########
be/src/vec/common/allocator.h:
##########
@@ -95,6 +96,8 @@ class Allocator {
/// Allocate memory range.
void* alloc(size_t size, size_t alignment = 0) {
memory_check(size);
+ doris::thread_context()->large_memory_check = false;
Review Comment:
因为 Allocator 申请大内存是符合预期的，
Allocator之外申请大内存不符合预期，如果发现了，期望能改用Allocator申请，否则内存超限后不受控制的大内存申请容易导致OOM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
