yiguolei commented on code in PR #22028:
URL: https://github.com/apache/doris/pull/22028#discussion_r1270224528
##########
be/src/exec/data_sink.h:
##########
@@ -67,7 +67,7 @@ class DataSink {
return Status::NotSupported("Not support send block");
}
- virtual void try_close(RuntimeState* state, Status exec_status) {}
+ virtual Status try_close(RuntimeState* state, Status exec_status) { return
Status::OK(); }
Review Comment:
add [[nodiscard]] attribute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
