[GitHub] [incubator-doris] imay commented on a change in pull request #4156: '[[' syntax works in bash, but is undefined in the default shell. '[[: not found' exception will raise in some cases.

Mon, 27 Jul 2020 02:59:12 -0700 


imay commented on a change in pull request #4156:
URL: https://github.com/apache/incubator-doris/pull/4156#discussion_r460780023



##########
File path: docs/en/installing/install-deploy.md
##########
@@ -149,7 +149,7 @@ BROKER does not currently have, nor does it need, priority\ 
networks. Broker's s
 
 * Start FE
 
-       `sh bin/start_fe.sh --daemon`
+       `bash bin/start_fe.sh --daemon`

Review comment:
       I see that start_fe.sh has '#!/usr/bin/env bash'. So system will use 
bash call this shell.
   So I think following will be better.
   ```suggestion
        `./bin/start_fe.sh --daemon`
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to