[GitHub] [incubator-doris] caiconghui commented on a change in pull request #4029: Support check committed txns before catalog drop meta, like db, table, partition etc

[GitBox]

caiconghui commented on a change in pull request #4029:
URL: https://github.com/apache/incubator-doris/pull/4029#discussion_r460699221



##########
File path: fe/src/main/cup/sql_parser.cup
##########
@@ -879,7 +879,11 @@ alter_table_clause ::=
     :}
     | KW_DROP opt_tmp:isTempPartition KW_PARTITION opt_if_exists:ifExists 
ident:partitionName
     {:
-        RESULT = new DropPartitionClause(ifExists, partitionName, 
isTempPartition);
+        RESULT = new DropPartitionClause(ifExists, partitionName, 
isTempPartition, !isTempPartition);
+    :}
+    | KW_DROPP opt_tmp:isTempPartition KW_PARTITION opt_if_exists:ifExists 
ident:partitionName

Review comment:
       @chaoyli I has fixed it before. old commit version?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org