dataroaring commented on code in PR #19917: URL: https://github.com/apache/doris/pull/19917#discussion_r1268008567
########## be/src/vec/sink/vtablet_block_convertor.cpp: ########## @@ -431,5 +454,42 @@ void OlapTableBlockConvertor::_convert_to_dest_desc_block(doris::vectorized::Blo } } +Status OlapTableBlockConvertor::_fill_auto_inc_cols(vectorized::Block* block, size_t rows, + bool eos) { + size_t idx = _auto_inc_col_idx.value(); + SlotDescriptor* slot = _output_tuple_desc->slots()[idx]; + DCHECK(slot->type().type == PrimitiveType::TYPE_BIGINT); + DCHECK(!slot->is_nullable()); + + vectorized::ColumnPtr src_column_ptr = block->get_by_position(idx).column; + const auto& src_nullable_column = + assert_cast<const vectorized::ColumnNullable&>(*src_column_ptr); + auto src_nested_column_ptr = src_nullable_column.get_nested_column_ptr(); + const auto& null_map_data = src_nullable_column.get_null_map_data(); + auto dst_column = vectorized::ColumnInt64::create(); + vectorized::ColumnInt64::Container& dst_values = dst_column->get_data(); + dst_values.reserve(rows); + + size_t null_value_count = 0; + for (size_t i = 0; i < rows; i++) { + null_value_count += null_map_data[idx]; + } + + DCHECK(_request_future.valid()); Review Comment: rename it to _auto_inc_request_future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org