morningman commented on code in PR #21953: URL: https://github.com/apache/doris/pull/21953#discussion_r1267617242
########## fe/fe-core/src/main/java/org/apache/doris/nereids/CascadesContext.java: ########## @@ -388,19 +389,24 @@ private Set<UnboundRelation> extractUnboundRelationFromCTE(LogicalCTE<?> cte) { return relations; } - private Table getTable(UnboundRelation unboundRelation) { + private TableIf getTable(UnboundRelation unboundRelation) { List<String> nameParts = unboundRelation.getNameParts(); switch (nameParts.size()) { case 1: { // table + String ctlName = getConnectContext().getEnv().getCurrentCatalog().getName(); Review Comment: Do we need to check if `current catalog` is set in `connection context`? Otherwise we may got NPE here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org