This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 87484be8dfdae37c9353acd3c2392bb8fa1ad500
Author: yiguolei <yiguo...@gmail.com>
AuthorDate: Sat Jul 8 22:33:43 2023 +0800
[bugfix](nullable) should check nullable info when build output block and
print more info when fatal
---
be/src/vec/exec/join/vjoin_node_base.cpp | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/be/src/vec/exec/join/vjoin_node_base.cpp
b/be/src/vec/exec/join/vjoin_node_base.cpp
index 0aaf0f1129..7b93f110ff 100644
--- a/be/src/vec/exec/join/vjoin_node_base.cpp
+++ b/be/src/vec/exec/join/vjoin_node_base.cpp
@@ -138,6 +138,11 @@ Status VJoinNodeBase::_build_output_block(Block*
origin_block, Block* output_blo
RETURN_IF_ERROR(_output_expr_ctxs[i]->execute(origin_block,
&result_column_id));
auto column_ptr =
origin_block->get_by_position(result_column_id)
.column->convert_to_full_column_if_const();
+ // check nullable here, and print more info about plan
+ if (!mutable_columns[i]->is_nullable() &&
column_ptr->is_nullable()) {
+ LOG(FATAL) << "to is not nullable while from is nullable,
could not copy. i = "
+ << i << ", exec_node_id = " << _id;
+ }
insert_column_datas(mutable_columns[i], *column_ptr, rows);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
