kaijchen commented on code in PR #21746:
URL: https://github.com/apache/doris/pull/21746#discussion_r1266353671
##########
be/src/olap/delta_writer.h:
##########
@@ -182,6 +186,8 @@ class DeltaWriter {
// total rows num written by DeltaWriter
int64_t _total_received_rows = 0;
+ // number of rows filtered in strict mode partial update
+ int64_t _num_rows_filtered = 0;
Review Comment:
this is unused
##########
be/src/olap/delta_writer.h:
##########
@@ -124,6 +124,10 @@ class DeltaWriter {
int64_t total_received_rows() const { return _total_received_rows; }
+ int64_t DeltaWriter::num_rows_filtered() {
Review Comment:
This does not compile, please move it to `.cpp` file.
In header, it should just be
```cpp
int64_t num_rows_filtered() const;
```
In cpp file (add the const)
```cpp
int64_t DeltaWriter::num_rows_filtered() const {
return _rowset_writer == nullptr ? 0 :
_rowset_writer->num_rows_filtered();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
