yiguolei commented on code in PR #21109: URL: https://github.com/apache/doris/pull/21109#discussion_r1266280514
########## be/test/vec/data_types/from_string_test.cpp: ########## @@ -0,0 +1,177 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "gtest/gtest_pred_impl.h" +#include "olap/types.h" // for TypeInfo +#include "olap/wrapper_field.h" +#include "vec/columns/column.h" +#include "vec/core/field.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_factory.hpp" +#include "vec/data_types/serde_utils.h" +#include "vec/io/reader_buffer.h" + +namespace doris::vectorized { + +/** + * This test is used to check wrapperField from_string is equal to data type from_string or not + * same string feed to wrapperField and data type from_string, and check the result from + * wrapperField and data type to_string is equal or not + */ +TEST(FromStringTest, ScalaWrapperFieldVsDataType) { Review Comment: std::string decimal32_val = "32.12" auto serde = createSerde(10,4); Column col = serde.from_string(col, decimal32_val); col.get_row_num(1) == 32.1200 std::string decimal32_val = "32.1234567891011" auto serde = createSerde(10,4); Column col = serde.from_string(col, decimal32_val); col.get_row_num(1) == 32.1200 serde = createserde(10,1) col.get_row_num(1) == 32.1 std::string decimal32_val = "32.16" auto serde = createSerde(10,1); col.get_row_num(1) == 32.2 ?? datetime datetimev2 (precision) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
