[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #4159: [Feature][Cache]Add interface, cache coordinator, metric, variable and config for query cache

[GitBox]

kangkaisen commented on a change in pull request #4159:
URL: https://github.com/apache/incubator-doris/pull/4159#discussion_r459311669



##########
File path: fe/fe-core/src/main/java/org/apache/doris/common/Config.java
##########
@@ -1117,5 +1117,34 @@
      */
     @ConfField
     public static String thrift_server_type = ThriftServer.THREAD_POOL;
-}
+    
+    /**
+     * If set to true, fe will enable sql result cache
+     * This option is suitable for offline data update scenarios
+     *                              case1   case2   case3   case4
+     * enable_sql_cache             false   true    true    false
+     * enable_partition_cache       false   false   true    true
+     */
+    @ConfField(mutable = true, masterOnly = false)
+    public static boolean enable_sql_cache = false;
+
+    /**
+     * If set to true, fe will get data from be cache,
+     * This option is suitable for real-time updating of partial partitions.
+     */
+    @ConfField(mutable = true, masterOnly = false)
+    public static boolean enable_partition_cache = false;

Review comment:
       Please add these configs to FE config doc.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org