WingsGo opened a new issue #4126:
URL: https://github.com/apache/incubator-doris/issues/4126
**Describe the bug**
When user use cmd like `alter table xxx set
("dynamic_partition.enable"="true");` , if the table is not a dynamic partition
table, It will throw a Exception like following
java.lang.NumberFormatException: null
at java.lang.Integer.parseInt(Integer.java:614) ~[?:?]
at java.lang.Integer.parseInt(Integer.java:770) ~[?:?]
at
org.apache.doris.catalog.DynamicPartitionProperty.<init>(DynamicPartitionProperty.java:60)
~[palo-fe.jar:?]
at
org.apache.doris.catalog.TableProperty.buildDynamicProperty(TableProperty.java:100)
~[palo-fe.jar:?]
at
org.apache.doris.catalog.Catalog.modifyTableDynamicPartition(Catalog.java:5167)
~[palo-fe.jar:?]
at
org.apache.doris.alter.SchemaChangeHandler.process(SchemaChangeHandler.java:1395)
~[palo-fe.jar:?]
at org.apache.doris.alter.Alter.processAlterTable(Alter.java:189)
~[palo-fe.jar:?]
at org.apache.doris.catalog.Catalog.alterTable(Catalog.java:4846)
~[palo-fe.jar:?]
at org.apache.doris.qe.DdlExecutor.execute(DdlExecutor.java:113)
~[palo-fe.jar:?]
at
org.apache.doris.qe.StmtExecutor.handleDdlStmt(StmtExecutor.java:870)
[palo-fe.jar:?]
at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:281)
[palo-fe.jar:?]
at
org.apache.doris.qe.ConnectProcessor.proxyExecute(ConnectProcessor.java:431)
[palo-fe.jar:?]
at
org.apache.doris.service.FrontendServiceImpl.forward(FrontendServiceImpl.java:577)
[palo-fe.jar:?]
at
org.apache.doris.thrift.FrontendService$Processor$forward.getResult(FrontendService.java:1633)
[palo-fe.jar:?]
at
org.apache.doris.thrift.FrontendService$Processor$forward.getResult(FrontendService.java:1618)
[palo-fe.jar:?]
at
org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
[libthrift-0.9.3.jar:0.9.3]
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
[libthrift-0.9.3.jar:0.9.3]
at
org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286)
[libthrift-0.9.3.jar:0.9.3]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[?:?]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[?:?]
at java.lang.Thread.run(Thread.java:834) [?:?]
It is because we forget to check if the table is a dynamic partition table,
it means that the table's dynamic property is null, so the current logic try to
create a new DynamicProperty with the property contains only one paramater.
https://github.com/apache/incubator-doris/blob/ad17afef9139a9aeedeb2e92638e95886d515f14/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java#L1394-L1396
**Solution**
Add check logic before alter a table's dynamic properties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
