morningman commented on code in PR #21700:
URL: https://github.com/apache/doris/pull/21700#discussion_r1261356079


##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1700,6 +1700,10 @@ public class Config extends ConfigBase {
         "Max number of hive partition values to return while list partitions, 
-1 means no limitation."})
     public static short max_hive_list_partition_num = -1;
 
+    @ConfField(mutable = false, masterOnly = false, description = 
{"远程文件系统缓存的最大数量",
+        "Max cache number of remote file system."})
+    public static long max_remote_file_system_cache_num = 1000;

Review Comment:
   usually, there is only several fs to connect, maybe 100 as default is enough.



##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreCache.java:
##########
@@ -122,6 +123,7 @@ public class HiveMetaStoreCache {
     // the ref of cache from <location> -> <file list>
     private volatile AtomicReference<LoadingCache<FileCacheKey, 
FileCacheValue>> fileCacheRef
             = new AtomicReference<>();
+    private FileSystemCache fsCache;

Review Comment:
   How about move it to `ExternalMetaCacheMgr`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to