kaijchen commented on code in PR #21456: URL: https://github.com/apache/doris/pull/21456#discussion_r1261076068
########## be/src/olap/olap_meta.cpp: ########## @@ -216,6 +216,29 @@ Status OlapMeta::put(const int column_family_index, const std::vector<BatchEntry return Status::OK(); } +Status OlapMeta::put(rocksdb::WriteBatch* batch) { + DorisMetrics::instance()->meta_write_request_total->increment(1); + + rocksdb::Status s; + { + int64_t duration_ns = 0; + Defer defer([&] { + DorisMetrics::instance()->meta_write_request_duration_us->increment(duration_ns / 1000); + }); + SCOPED_RAW_TIMER(&duration_ns); + + WriteOptions write_options; + write_options.sync = config::sync_tablet_meta; + s = _db->Write(write_options, batch); + } + + if (!s.ok()) { + LOG(WARNING) << "rocks db put batch failed, reason:" << s.ToString(); + return Status::Error<META_PUT_ERROR>(); Review Comment: Compile Error on this line. Please provide an error message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org