HappenLee commented on code in PR #21722:
URL: https://github.com/apache/doris/pull/21722#discussion_r1260549077
##########
be/src/vec/functions/function_date_or_datetime_computation.h:
##########
@@ -1093,6 +1093,27 @@ struct TimeToSecImpl {
}
};
+struct SecToTimeImpl {
+ using ReturnType = DataTypeTime;
+ static constexpr auto name = "sec_to_time";
+ static Status execute(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) {
+ auto res_col = ColumnFloat64::create();
+ const auto& [argument_column, arg_const] =
Review Comment:
`use_default_implementation_for_constants ` is true, no need to dispose the
const column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
