acelyc111 commented on a change in pull request #4106:
URL: https://github.com/apache/incubator-doris/pull/4106#discussion_r455894385
##########
File path: be/src/http/default_path_handlers.h
##########
@@ -20,6 +20,8 @@
#include <stdio.h>
+#include "util/thread.h"
Review comment:
You can move this include to cpp file to reduce includes in header files
##########
File path: be/src/env/env_util.cpp
##########
@@ -46,5 +47,59 @@ Status open_file_for_random(Env *env, const string &path,
shared_ptr<RandomAcces
return Status::OK();
}
+static Status do_write_string_to_file(Env* env, const Slice& data,
+ const std::string& fname,
Review comment:
indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
