yiguolei commented on code in PR #21505:
URL: https://github.com/apache/doris/pull/21505#discussion_r1257442367
##########
be/src/olap/compaction.cpp:
##########
@@ -625,6 +625,10 @@ Status Compaction::modify_rowsets(const
Merger::Statistics* stats) {
{
std::shared_lock rlock(_tablet->get_header_lock());
+ if (compaction_type() == ReaderType::READER_CUMULATIVE_COMPACTION &&
+ config::compaction_policy == CUMULATIVE_TIME_SERIES_POLICY) {
+ _tablet->save_cumulative_layer_point(_output_rowset->end_version()
+ 1);
Review Comment:
why add this method? because in line 632, it will call save_meta method, I
think you could just modify the memory state and it will be saved in save_meta?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
