morningman commented on code in PR #21514:
URL: https://github.com/apache/doris/pull/21514#discussion_r1257391236
##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -91,7 +91,7 @@ CsvReader::CsvReader(RuntimeState* state, RuntimeProfile*
profile, ScannerCounte
_file_compress_type = _params.compress_type;
_size = _range.size;
- _text_converter.reset(new (std::nothrow) TextConverter('\\'));
+ _text_converter.reset(new (std::nothrow)
TextConverter('\\',_array_delimiter[0]));
Review Comment:
```suggestion
_text_converter.reset(new (std::nothrow) TextConverter('\\',
_array_delimiter[0]));
```
##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -91,7 +91,7 @@ CsvReader::CsvReader(RuntimeState* state, RuntimeProfile*
profile, ScannerCounte
_file_compress_type = _params.compress_type;
_size = _range.size;
- _text_converter.reset(new (std::nothrow) TextConverter('\\'));
+ _text_converter.reset(new (std::nothrow)
TextConverter('\\',_array_delimiter[0]));
Review Comment:
You can run `sh build-support/clang-format.sh` to format this automatically.
##########
be/src/exec/text_converter.h:
##########
@@ -29,7 +29,7 @@ class SlotDescriptor;
// numeric types, etc.
class TextConverter {
public:
- TextConverter(char escape_char);
+ TextConverter(char escape_char ,char array_delimiter ='\2');
Review Comment:
```suggestion
TextConverter(char escape_char, char array_delimiter ='\2');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
