airborne12 commented on code in PR #21611:
URL: https://github.com/apache/doris/pull/21611#discussion_r1255301411
##########
be/src/io/fs/multi_table_pipe.h:
##########
@@ -74,7 +74,7 @@ class MultiTablePipe : public KafkaConsumerPipe {
std::atomic<uint64_t> _unplanned_row_cnt {0}; // trigger plan request when
exceed threshold
std::atomic<uint64_t> _inflight_plan_cnt {0}; // how many plan fragment
are executing?
std::atomic<bool> _consume_finished {false};
- std::shared_ptr<StreamLoadContext> _ctx;
+ StreamLoadContext* _ctx;
Review Comment:
No safe to use row pointer
Is there a cycle reference for StreamLoadContext shared_ptr which causes
memory is not deallocated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
