shuke987 opened a new pull request, #21556: URL: https://github.com/apache/doris/pull/21556
## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> In some situation, _handle_mem_exceed_limit will alloc a large memory block, more than 5G. After add some log, we found that: 1. alloc memory was made in vector::insert_realloc 2. writers_to_reduce_mem's size is more than 8 million. which indicated an infinite loop is met in while (!tablets_mem_heap.empty()). By reviewing codes, """ if (std::get<0>(tablet_mem_item)++ != std::get<1>(tablet_mem_item)) """ is wrong, which must be """ if (++std::get<0>(tablet_mem_item) != std::get<1>(tablet_mem_item)) """. In the original code, we will made ++ on end iterator, and the compare to end iterator, which's behavior is undefined. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
