[GitHub] [doris] xiaokang commented on a diff in pull request #21310: [bugfix](ngram bf index) process differently for normal bloom filter index and ngram bf index

[via GitHub]

xiaokang commented on code in PR #21310:
URL: https://github.com/apache/doris/pull/21310#discussion_r1253803673


##########
be/src/olap/null_predicate.h:
##########
@@ -92,7 +94,7 @@ class NullPredicate : public ColumnPredicate {
         }
     }
 
-    bool can_do_bloom_filter() const override { return _is_null; }
+    bool can_do_bloom_filter(bool ngram) const override { return ngram ? false 
: _is_null; }

Review Comment:
   changed



##########
be/src/olap/rowset/segment_v2/column_reader.h:
##########
@@ -137,7 +137,12 @@ class ColumnReader {
 
     bool has_zone_map() const { return _zone_map_index_meta != nullptr; }
     bool has_bitmap_index() const { return _bitmap_index_meta != nullptr; }
-    bool has_bloom_filter_index() const { return _bf_index_meta != nullptr; }
+    bool has_bloom_filter_index(bool ngram) const {
+        return _bf_index_meta != nullptr &&
+               (ngram ? (_bf_index_meta->algorithm() == 
BloomFilterAlgorithmPB::NGRAM_BLOOM_FILTER)
+                      : (_bf_index_meta->algorithm() !=
+                         BloomFilterAlgorithmPB::NGRAM_BLOOM_FILTER));
+    }

Review Comment:
   changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org