zhannngchen commented on code in PR #21456: URL: https://github.com/apache/doris/pull/21456#discussion_r1251605482
########## be/src/olap/data_dir.cpp: ########## @@ -539,6 +540,24 @@ Status DataDir::load() { } } + auto load_delete_bitmap_func = [this](int64_t tablet_id, RowsetId rowset_id, int64_t segment_id, + int64_t version, const string& val) { + TabletSharedPtr tablet = _tablet_manager->get_tablet(tablet_id); + if (!tablet) { + return true; + } + const std::vector<RowsetMetaSharedPtr>& all_rowsets = tablet->tablet_meta()->all_rs_metas(); + for (auto& rowset_meta : all_rowsets) { + // only process the rowset in _rs_metas + if (rowset_meta->rowset_id() == rowset_id) { + tablet->tablet_meta()->delete_bitmap().delete_bitmap[{ + rowset_id, segment_id, version}] |= roaring::Roaring::read(val.data()); + } + } + return true; + }; + TabletMetaManager::traverse_delete_bitmap(_meta, load_delete_bitmap_func); Review Comment: We need to add some correctness check here when recovery -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org