github-actions[bot] commented on PR #21421:
URL: https://github.com/apache/doris/pull/21421#issuecomment-1617161737
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5440202402";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 106:
echo "FE_HOST: ${FE_HOST}"
^--------^ SC2154 (warning): FE_HOST is referenced but not
assigned.
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 107:
echo "FE_QUERY_PORT: ${FE_QUERY_PORT}"
^--------------^ SC2154 (warning): FE_QUERY_PORT is
referenced but not assigned.
In tools/tpcds-tools/bin/run-tpcds-queries.sh line 109:
echo "DB: ${DB}"
^---^ SC2154 (warning): DB is referenced but not assigned.
For more information:
https://www.shellcheck.net/wiki/SC2154 -- DB is referenced but not
assigned.
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/tpcds-tools/bin/create-tpcds-tables.sh.orig
+++ tools/tpcds-tools/bin/create-tpcds-tables.sh
@@ -59,9 +59,9 @@
shift
;;
-s)
- SCALE_FACTOR=$2
- shift 2
- ;;
+ SCALE_FACTOR=$2
+ shift 2
+ ;;
--)
shift
break
@@ -110,7 +110,7 @@
elif [[ ${SCALE_FACTOR} -eq 100 ]]; then
echo "Run SQLs from ${CURDIR}/../ddl/create-tpcds-tables-sf100.sql"
mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
<"${CURDIR}"/../ddl/create-tpcds-tables-sf100.sql
-else
+else
echo "${SCALE_FACTOR} scale is NOT supported currently"
fi
--- tools/tpcds-tools/bin/run-tpcds-queries.sh.orig
+++ tools/tpcds-tools/bin/run-tpcds-queries.sh
@@ -59,9 +59,9 @@
shift
;;
-s)
- SCALE_FACTOR=$2
- shift 2
- ;;
+ SCALE_FACTOR=$2
+ shift 2
+ ;;
--)
shift
break
@@ -78,14 +78,14 @@
fi
if [[ ${SCALE_FACTOR} -eq 1 ]]; then
- echo "Running tpcds sf 1 queries"
- TPCDS_QUERIES_DIR="${CURDIR}/../queries_1"
+ echo "Running tpcds sf 1 queries"
+ TPCDS_QUERIES_DIR="${CURDIR}/../queries_1"
elif [[ ${SCALE_FACTOR} -eq 100 ]]; then
- echo "Running tpcds sf 100 queries"
- TPCDS_QUERIES_DIR="${CURDIR}/../queries_100"
+ echo "Running tpcds sf 100 queries"
+ TPCDS_QUERIES_DIR="${CURDIR}/../queries_100"
else
- echo "${SCALE_FACTOR} scale is NOT support currently."
- exit 1
+ echo "${SCALE_FACTOR} scale is NOT support currently."
+ exit 1
fi
check_prerequest() {
@@ -137,19 +137,19 @@
hot2=0
echo -ne "query${i}\t" | tee -a result.csv
start=$(date +%s%3N)
- mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments < "${TPCDS_QUERIES_DIR}"/query"${i}".sql > /dev/null
+ mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments <"${TPCDS_QUERIES_DIR}"/query"${i}".sql >/dev/null
end=$(date +%s%3N)
cold=$((end - start))
echo -ne "${cold}\t" | tee -a result.csv
start=$(date +%s%3N)
- mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments < "${TPCDS_QUERIES_DIR}"/query"${i}".sql > /dev/null
+ mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments <"${TPCDS_QUERIES_DIR}"/query"${i}".sql >/dev/null
end=$(date +%s%3N)
hot1=$((end - start))
echo -ne "${hot1}\t" | tee -a result.csv
start=$(date +%s%3N)
- mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments < "${TPCDS_QUERIES_DIR}"/query"${i}".sql > /dev/null
+ mysql -h"${FE_HOST}" -u"${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments <"${TPCDS_QUERIES_DIR}"/query"${i}".sql >/dev/null
end=$(date +%s%3N)
hot2=$((end - start))
echo -ne "${hot2}\t" | tee -a result.csv
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
