xinyiZzz commented on code in PR #21311: URL: https://github.com/apache/doris/pull/21311#discussion_r1249984441
########## be/src/vec/common/allocator.cpp: ########## @@ -48,6 +49,9 @@ void Allocator<clear_memory_, mmap_populate, use_mmap>::sys_memory_check(size_t size, doris::thread_context()->thread_mem_tracker()->label(), doris::thread_context()->thread_mem_tracker_mgr->last_consumer_tracker(), doris::MemTrackerLimiter::process_limit_exceeded_errmsg_str()); + if (size > 1024l * 1024 * 1024) { // 1G + err_msg += "\nAlloc Stacktrace:\n" + doris::get_stack_trace(); Review Comment: 我加个条件,如果 size 大于系统剩余可用内存 && 外面没有catch bad alloc,则打日志, 目的是如果内存超限后瞬间OOM,找到那个大内存申请 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org