HappenLee commented on code in PR #21360:
URL: https://github.com/apache/doris/pull/21360#discussion_r1249962657
##########
be/src/vec/exec/join/vjoin_node_base.cpp:
##########
@@ -183,13 +192,18 @@ Status VJoinNodeBase::_build_output_block(Block*
origin_block, Block* output_blo
for (int i = 0; i < mutable_columns.size(); ++i) {
auto result_column_id = -1;
RETURN_IF_ERROR(_output_expr_ctxs[i]->execute(origin_block,
&result_column_id));
- auto column_ptr =
origin_block->get_by_position(result_column_id)
-
.column->convert_to_full_column_if_const();
- insert_column_datas(mutable_columns[i], *column_ptr, rows);
+ auto& origin_column =
origin_block->get_by_position(result_column_id).column;
Review Comment:
TODO: need better dispose the const column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
