starocean999 commented on code in PR #21331:
URL: https://github.com/apache/doris/pull/21331#discussion_r1247503104
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/combinator/MergeCombinator.java:
##########
@@ -47,13 +46,12 @@ public MergeCombinator(List<Expression> arguments,
AggregateFunction nested) {
super(nested.getName() + AggStateFunctionBuilder.MERGE_SUFFIX,
arguments);
this.nested = Objects.requireNonNull(nested, "nested can not be null");
- inputType = new AggStateType(nested.getName(),
nested.getArgumentsTypes(),
-
nested.getArguments().stream().map(Expression::nullable).collect(Collectors.toList()));
+ inputType = (AggStateType) arguments.get(0).getDataType();
Review Comment:
please check if StateCombinator and UnionCombinator should do the same thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
