sohardforaname commented on code in PR #18257:
URL: https://github.com/apache/doris/pull/18257#discussion_r1247382946
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FunctionBinder.java:
##########
@@ -86,7 +88,7 @@ public Expression visitUnboundFunction(UnboundFunction
unboundFunction, Expressi
.map(e -> e.accept(this,
context)).collect(Collectors.toList()));
// bind function
- FunctionRegistry functionRegistry =
context.cascadesContext.getConnectContext().getFunctionRegistry();
+ FunctionRegistry functionRegistry =
Env.getCurrentEnv().getFunctionRegistry();
Review Comment:
because the connect context also get registry from env. In replaying
function phase, connect context is null, this way is to avoid it.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/FunctionBinder.java:
##########
@@ -86,7 +88,7 @@ public Expression visitUnboundFunction(UnboundFunction
unboundFunction, Expressi
.map(e -> e.accept(this,
context)).collect(Collectors.toList()));
// bind function
- FunctionRegistry functionRegistry =
context.cascadesContext.getConnectContext().getFunctionRegistry();
+ FunctionRegistry functionRegistry =
Env.getCurrentEnv().getFunctionRegistry();
Review Comment:
because the connect context also get registry from env. In replaying
function phase, connect context is null, this way is to avoid npe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
