liutang123 commented on a change in pull request #4011:
URL: https://github.com/apache/incubator-doris/pull/4011#discussion_r449985800
##########
File path: be/src/olap/tablet.cpp
##########
@@ -826,6 +832,33 @@ void Tablet::_print_missed_versions(const
std::vector<Version>& missed_versions)
LOG(WARNING) << ss.str();
}
+bool Tablet::_drop_rowset_if_version_conflict(const RowsetSharedPtr& rowset) {
Review comment:
Why don't we need to do `do_tablet_meta_checkpoint` when adding a rs,
but we need to do it when we delete a rs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
