yiguolei commented on code in PR #20771:
URL: https://github.com/apache/doris/pull/20771#discussion_r1245986845


##########
be/src/vec/sink/vtablet_sink.cpp:
##########
@@ -118,6 +118,8 @@ class OpenPartitionClosure : public 
google::protobuf::Closure {
                                                       
vnode_channel->channel_info(), ss.str()),
                                           -1);
         }
+        done = true;

Review Comment:
   这个done 得是atomic的,否则一个线程更新了,另外一个thread 看不见



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to