morningman commented on code in PR #20996:
URL: https://github.com/apache/doris/pull/20996#discussion_r1234096227


##########
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java:
##########
@@ -351,17 +348,12 @@ private ArrayList<AddPartitionClause> 
getAddPartitionClause(Database db, OlapTab
      */
     private void setStorageMediumProperty(HashMap<String, String> 
partitionProperties,
             DynamicPartitionProperty property, ZonedDateTime now, int 
hotPartitionNum, int offset) {
-        if ((hotPartitionNum <= 0 || offset + hotPartitionNum <= 0) && 
!property.getStorageMedium()
+        if (hotPartitionNum <= 0 || offset + hotPartitionNum <= 0 || 
property.getStorageMedium()
                 .equalsIgnoreCase("ssd")) {
             return;
         }
-        String cooldownTime;
-        if (property.getStorageMedium().equalsIgnoreCase("ssd")) {
-            cooldownTime = 
TimeUtils.longToTimeString(DataProperty.MAX_COOLDOWN_TIME_MS);

Review Comment:
   why remove this line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to