[GitHub] [doris] Jibing-Li commented on a diff in pull request #20906: [Improvement](multi catalog, statistics)Support two level external statistics cache loader.

[via GitHub]

Jibing-Li commented on code in PR #20906:
URL: https://github.com/apache/doris/pull/20906#discussion_r1233562058


##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStatisticsCacheLoader.java:
##########
@@ -42,20 +43,39 @@ public class ColumnStatisticsCacheLoader extends 
StatisticsCacheLoader<Optional<
 
     @Override
     protected Optional<ColumnStatistic> doLoad(StatisticsCacheKey key) {
+        // Load from statistics table.
+        Optional<ColumnStatistic> columnStatistic = 
loadFromStatsTable(String.valueOf(key.tableId),
+                String.valueOf(key.idxId), key.colName);
+        if (columnStatistic.isPresent()) {
+            return columnStatistic;
+        }
+        // Load from data source metadata
+        try {
+            TableIf table = 
Env.getCurrentEnv().getCatalogMgr().getCatalog(key.catalogId)

Review Comment:
   内表如果走到这里不会去查，直接返回Optional.empty();



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org