zhannngchen commented on code in PR #20883: URL: https://github.com/apache/doris/pull/20883#discussion_r1231790793
########## be/src/olap/delta_writer.cpp: ########## @@ -453,6 +453,7 @@ Status DeltaWriter::close_wait(const PSlaveTabletNodes& slave_tablet_nodes, RETURN_IF_ERROR(_tablet->calc_delete_bitmap_between_segments(_cur_rowset, segments, _delete_bitmap)); } + std::shared_lock meta_rlock(_tablet->get_header_lock()); Review Comment: should hold the lock inside max_version() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org