kaijchen opened a new pull request, #20764: URL: https://github.com/apache/doris/pull/20764
## Proposed changes In #20308, we've changed the semantics of `num_segment` in `BetaRowsetWriter` in order to forfill the need of `atomic_num_segments` in `generate_delete_bitmap`. However, after #20446, it turns out `generate_delete_bitmap` don't need `num_segment` anymore. This patch attempts to restore the semantics of `num_segment` in `BetaRowsetWriter`, clear the TODOs and hopefully integrates better with code paths other than `DeltaWriter::_flush_memtable_async`. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
