This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 565095eb52 [bug](function) fix is_null/is_not_null check is_const has
error (#20562)
565095eb52 is described below
commit 565095eb5221f2396a483002b2dbc621b7950796
Author: zhangstar333 <87313068+zhangstar...@users.noreply.github.com>
AuthorDate: Mon Jun 12 18:21:12 2023 +0800
[bug](function) fix is_null/is_not_null check is_const has error (#20562)
fix is_null/is_not_null check is_const has error
---
.../java/org/apache/doris/analysis/Analyzer.java | 2 +
.../doris/rewrite/RewriteIsNullIsNotNullRule.java | 55 ++++++++++++++++++++++
2 files changed, 57 insertions(+)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
index c76cb0fa0b..d56a9d55bd 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
@@ -62,6 +62,7 @@ import org.apache.doris.rewrite.RewriteEncryptKeyRule;
import org.apache.doris.rewrite.RewriteFromUnixTimeRule;
import org.apache.doris.rewrite.RewriteImplicitCastRule;
import org.apache.doris.rewrite.RewriteInPredicateRule;
+import org.apache.doris.rewrite.RewriteIsNullIsNotNullRule;
import org.apache.doris.rewrite.RoundLiteralInBinaryPredicatesRule;
import org.apache.doris.rewrite.mvrewrite.CountDistinctToBitmap;
import org.apache.doris.rewrite.mvrewrite.CountDistinctToBitmapOrHLLRule;
@@ -430,6 +431,7 @@ public class Analyzer {
rules.add(RewriteEncryptKeyRule.INSTANCE);
rules.add(RewriteInPredicateRule.INSTANCE);
rules.add(RewriteAliasFunctionRule.INSTANCE);
+ rules.add(RewriteIsNullIsNotNullRule.INSTANCE);
rules.add(MatchPredicateRule.INSTANCE);
rules.add(EliminateUnnecessaryFunctions.INSTANCE);
List<ExprRewriteRule> onceRules = Lists.newArrayList();
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteIsNullIsNotNullRule.java
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteIsNullIsNotNullRule.java
new file mode 100644
index 0000000000..69dabb95ed
--- /dev/null
+++
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteIsNullIsNotNullRule.java
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.rewrite;
+
+import org.apache.doris.analysis.Analyzer;
+import org.apache.doris.analysis.Expr;
+import org.apache.doris.analysis.FunctionCallExpr;
+import org.apache.doris.analysis.LiteralExpr;
+import org.apache.doris.catalog.Function;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.AnalysisException;
+
+// if the input arg is not nullable, so the function of is_null/is_not_null
+// result is very certain and there is no need to look at data in column.
+// just given a literal, so that BE could deal with it as const
+public class RewriteIsNullIsNotNullRule implements ExprRewriteRule {
+ public static ExprRewriteRule INSTANCE = new RewriteIsNullIsNotNullRule();
+
+ @Override
+ public Expr apply(Expr expr, Analyzer analyzer, ExprRewriter.ClauseType
clauseType) throws AnalysisException {
+ if (expr instanceof FunctionCallExpr) {
+ FunctionCallExpr functionExpr = ((FunctionCallExpr) expr);
+ Function fn = functionExpr.getFn();
+ if (fn == null) {
+ return expr;
+ }
+ if (fn.getFunctionName().getFunction().equals("is_null_pred")
+ && functionExpr.getChild(0).isNullable() == false) {
+ LiteralExpr literal = LiteralExpr.create("0", Type.BOOLEAN);
+ return literal;
+ }
+ if (fn.getFunctionName().getFunction().equals("is_not_null_pred")
+ && functionExpr.getChild(0).isNullable() == false) {
+ LiteralExpr literal = LiteralExpr.create("1", Type.BOOLEAN);
+ return literal;
+ }
+ }
+ return expr;
+ }
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
