luozenglin commented on code in PR #20242:
URL: https://github.com/apache/doris/pull/20242#discussion_r1226156437


##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Role.java:
##########
@@ -53,12 +55,21 @@ public class Role implements Writable, GsonPostProcessable {
     // admin is like DBA, who has all privileges except for NODE privilege 
held by operator
     public static String ADMIN_ROLE = "admin";
 
-    public static Role OPERATOR = new Role(OPERATOR_ROLE,
-            TablePattern.ALL, PrivBitSet.of(Privilege.NODE_PRIV, 
Privilege.ADMIN_PRIV),
-            ResourcePattern.ALL, PrivBitSet.of(Privilege.NODE_PRIV, 
Privilege.ADMIN_PRIV));
-    public static Role ADMIN = new Role(ADMIN_ROLE,
-            TablePattern.ALL, PrivBitSet.of(Privilege.ADMIN_PRIV),
-            ResourcePattern.ALL, PrivBitSet.of(Privilege.ADMIN_PRIV));
+    public static Role OPERATOR;
+    public static Role ADMIN;
+
+    static {
+        try {
+            // Global privileges do not distinguish Patter, global admin and 
node privileges contain all privileges

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to