[GitHub] [doris] caiconghui commented on a diff in pull request #20480: [fix](alter) fix potential concurrent issue for alter when check olap table state normal outside write lock scope is not atomic

[via GitHub]

caiconghui commented on code in PR #20480:
URL: https://github.com/apache/doris/pull/20480#discussion_r1224362975


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -1489,21 +1489,9 @@ public long getReplicaCount() {
         return replicaCount;
     }
 
-    public void checkStableAndNormal(String clusterName) throws DdlException {
+    public void checkNormalStateForAlter() throws DdlException {
         if (state != OlapTableState.NORMAL) {
-            throw new DdlException("Table[" + name + "]'s state is not NORMAL. 
"
-                    + "Do not allow doing materialized view");
-        }
-        // check if all tablets are healthy, and no tablet is in tablet 
scheduler
-        boolean isStable = isStable(Env.getCurrentSystemInfo(),

Review Comment:
   actually checkTableStable function will check table stable, no need to 
double check here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org