BiteTheDDDDt commented on code in PR #20164:
URL: https://github.com/apache/doris/pull/20164#discussion_r1217728506
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java:
##########
@@ -430,10 +442,44 @@ public Expr visitIsNull(IsNull isNull,
PlanTranslatorContext context) {
return new IsNullPredicate(isNull.child().accept(this, context),
false, true);
}
+ @Override
+ public Expr visitStateCombinator(StateCombinator combinator,
PlanTranslatorContext context) {
+ List<Expr> arguments = combinator.getArguments().stream().map(arg ->
arg.accept(this, context))
+ .collect(Collectors.toList());
+ return Function.convertToStateCombinator(new FunctionCallExpr(
+ translateAggregateFunction(combinator.getNestedFunction()),
new FunctionParams(false, arguments)));
+ }
+
+ @Override
+ public Expr visitMergeCombinator(MergeCombinator combinator,
PlanTranslatorContext context) {
+ List<Expr> arguments = combinator.getArguments().stream().map(arg ->
arg.accept(this, context))
+ .collect(Collectors.toList());
+ return Function.convertToMergeCombinator(new FunctionCallExpr(
+ translateAggregateFunction(combinator.getNestedFunction()),
new FunctionParams(false, arguments)));
+ }
+
+ private org.apache.doris.catalog.AggregateFunction
translateAggregateFunction(AggregateFunction function) {
Review Comment:
This logic can be used for both
`translateAggregateFunction`/`visitStateCombinator`/`visitMergeCombinator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
