yiguolei commented on code in PR #20408:
URL: https://github.com/apache/doris/pull/20408#discussion_r1217291980
##########
be/src/olap/rowset/beta_rowset_reader.cpp:
##########
@@ -304,10 +304,12 @@ Status
BetaRowsetReader::next_block_view(vectorized::BlockView* block_view) {
bool BetaRowsetReader::_should_push_down_value_predicates() const {
// if unique table with rowset [0-x] or [0-1] [2-y] [...],
- // value column predicates can be pushdown on rowset [0-x] or [2-y], [2-y]
must be compaction and not overlapping
+ // value column predicates can be pushdown on rowset [0-x] or [2-y], [2-y]
+ // must be compaction, not overlapping and don't have sequence column
return _rowset->keys_type() == UNIQUE_KEYS &&
Review Comment:
If _should_push_down_value_predicates returns false, then the value
predicates is not evaluated in segment iterator. Then when are these value
predicates evaluated？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
