morningman commented on a change in pull request #3860:
URL: https://github.com/apache/incubator-doris/pull/3860#discussion_r439837920
##########
File path: be/src/olap/tablet.cpp
##########
@@ -852,12 +853,11 @@ TabletInfo Tablet::get_tablet_info() const {
return TabletInfo(tablet_id(), schema_hash(), tablet_uid());
}
-void Tablet::pick_candicate_rowsets_to_cumulative_compaction(int64_t
skip_window_sec,
-
std::vector<RowsetSharedPtr>* candidate_rowsets) {
- int64_t now = UnixSeconds();
+void Tablet::pick_candicate_rowsets_to_cumulative_compaction(
+ std::vector<RowsetSharedPtr>* candidate_rowsets) {
ReadLock rdlock(&_meta_lock);
for (auto& it : _rs_version_map) {
- if (it.first.first >= _cumulative_point && (it.second->creation_time()
+ skip_window_sec < now)) {
+ if (it.first.first >= _cumulative_point) {
Review comment:
For reviewer: Remove the `skip_window_sec` check here, it will be
checked later in cumulative compaction process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
